Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise Data.Value union #6222

Closed
wants to merge 6 commits into from
Closed

Optimise Data.Value union #6222

wants to merge 6 commits into from

Conversation

ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Jun 18, 2024 •
edited
Loading

Part of #6142

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@ana-pantilie
First prototype of optimised Data Value union
04ef674 
Signed-off-by: Ana Pantilie <[email protected]>
@ana-pantilie
Partial fix
3aa4408 
Signed-off-by: Ana Pantilie <[email protected]>
@ana-pantilie
Fix unionWith algorithm
65569c7 
Signed-off-by: Ana Pantilie <[email protected]>
@ana-pantilie
Temp
37abbea 
Signed-off-by: Ana Pantilie <[email protected]>
@ana-pantilie
WIP algorithm based on merge sort
d3a8e9a 
Signed-off-by: Ana Pantilie <[email protected]>
@ana-pantilie
Temp
8fe3d5f 
Signed-off-by: Ana Pantilie <[email protected]>
@zeme-wana zeme-wana force-pushed the master branch 2 times, most recently from a161078 to db5cabb Compare July 9, 2024 09:24
@ana-pantilie
Copy link
Contributor Author

Closing because I haven't found a way to optimise this yet and will not work on this in the immediate future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ana-pantilie